Fix proxy-to-worker + modularize error reporting #23517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
proxy_to_worker_es6
branch
from
6ef92e2 to
6827eb5
Compare
kripken
reviewed
Jan 28, 2025
sbc100
force-pushed
the
proxy_to_worker_es6
branch
from
6827eb5 to
f480cf7
Compare
This configuration is not supported by was going undetected when `-sEXPORT_ES6` was used due to the order to checking vs setting the `MODULARIZE` setting.
sbc100
force-pushed
the
proxy_to_worker_es6
branch
from
f480cf7 to
604984f
Compare
Collaborator
Author
|
Note: This change doesn't add or remove any checks, it only changes the ordering so that we don't check the |
kripken
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configuration is not supported by was going undetected when
-sEXPORT_ES6was used due to the order to checking vs setting theMODULARIZEsetting.This change doesn't add or remove any checks, it only changes the ordering so we don't check settings before they are set.