NFC Factor out common code between updateGOT and reportUndefinedSymbols #22124
+24
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested in discussion on emscripten-core#22053
|
@sbc100 I think the failure is a flake. |
|
I re-ran tests here but the error recurred, though it did look like a flake. I tried to update the branch to fix that but now more tests fail, so there may be a larger issue here. |
sbc100
reviewed
Jul 2, 2024
| @@ -201,9 +201,30 @@ var LibraryDylink = { | |||
| #endif | |||
| ; | |||
| }, | |||
| $setGOTEntry__deps: ['$addFunction', '$getFunctionAddress'], | |||
| $setGOTEntry: (symName, value) => { | |||
| const entry = GOT[symName]; | |||
There was a problem hiding this comment.
It looks like both calls sites already have looked up the entry so perhaps we can pass the entry here too to avoid this extra lookup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in discussion on #22053