Replace .concat with push and/or spread operator. NFC
#22067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
.push over .concat in modules.mjs. NFC.concat with push and/or spread operator. NFC
kripken
reviewed
Jun 6, 2024
src/library_openal.js
Outdated
| @@ -842,7 +842,7 @@ var LibraryOpenAL = { | |||
| case {{{ cDefs.AL_VELOCITY }}}: | |||
| return AL.currentCtx.listener.velocity; | |||
| case {{{ cDefs.AL_ORIENTATION }}}: | |||
| return AL.currentCtx.listener.direction.concat(AL.currentCtx.listener.up); | |||
| return AL.currentCtx.listener.direction + AL.currentCtx.listener.up; | |||
There was a problem hiding this comment.
These are arrays so this changes the result, doesn't it? E.g.
> [0, 0, 0] + [1, 2, 3]
'0,0,01,2,3'
> [0, 0, 0].concat([1, 2, 3])
[ 0, 0, 0, 1, 2, 3 ]
kripken
reviewed
Jun 6, 2024
| @@ -1 +1 @@ | |||
| 4475 | |||
| 4553 | |||
There was a problem hiding this comment.
Odd that this increases code size?
There was a problem hiding this comment.
Interesting yes... maybe I'll split out the internal stuff and land that on its own.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 11, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 11, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 11, 2024
sbc100
added a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.