WebGPU: Add uncapturedErrorCallbackInfo to requestDevice descriptor #22044
Conversation
beaufortfrancois
force-pushed
the
uncaptured
branch
from
25fcf04
to
72207ea
Compare
|
@kainino0x This PR is ready for review now. |
src/library_webgpu.js
Outdated
| assert(typeof GPUValidationError != 'undefined'); | ||
| assert(typeof GPUOutOfMemoryError != 'undefined'); | ||
| #endif | ||
| if (ev.error instanceof GPUValidationError) type = Validation; |
There was a problem hiding this comment.
old code, but let's update it:
Use the compile-time constants like {{{ gpu.ErrorType.Validation }}} instead
There was a problem hiding this comment.
I've updated this part.
src/library_webgpu.js
Outdated
| // WGPUErrorType type, const char* message, void* userdata | ||
| var Validation = 0x00000001; | ||
| var OutOfMemory = 0x00000002; | ||
| var type; |
There was a problem hiding this comment.
Default to {{{ gpu.ErrorType.Unknown }}}
| @@ -54,7 +54,11 @@ void GetAdapter(void (*callback)(wgpu::Adapter)) { | |||
| } | |||
|
|
|||
| void GetDevice(void (*callback)(wgpu::Device)) { | |||
| adapter.RequestDevice(nullptr, [](WGPURequestDeviceStatus status, WGPUDevice cDevice, const char* message, void* userdata) { | |||
| wgpu::DeviceDescriptor desc{}; | |||
| desc.uncapturedErrorCallbackInfo = {nullptr, [](WGPUErrorType type, char const* message, void*) { | |||
There was a problem hiding this comment.
I totally forgot this but this reminded me - the C++ bindings still don't use the correct types (C++ types instead of C types) and we still have a breaking change planned to fix that. Loko is going to do that soon but we don't have it yet.
In the interest of stability of the Emscripten bindings I suppose we should delay this change for now, since it's just going to have to change again?
(As I think I've mentioned we're going to try to push breaking changes to a single big release down the road as much as possible.)
There was a problem hiding this comment.
Let's wait until @lokokung's 🪄 then ;)
There was a problem hiding this comment.
I believe https://dawn-review.googlesource.com/c/dawn/+/192741 should help
Following up on https://github.com/beaufortfrancois/webgpu-cross-platform-app/pull/7/files#r1602327969, I'm adding
uncapturedErrorCallbackInfoto requestDevice descriptor.