Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add webview tests #22042

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

seanmorris
Copy link
Contributor

@seanmorris seanmorris commented Jun 2, 2024

This PR adds a 'webview' browser and uses it to run CI tests.

title: "browser"
# Skip test_4gb_fail as it OOMs on the current bot
test_targets: "
browser skip:browser.test_4gb_fail
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to be running all browser tests in this mode or should we just run a select few?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this entire suite is large (and as a result slow) I would support picking a select few to run.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can write a specific test for loading from file:// URLs since that is the only different that I currently know of between webview and non-webview browsers. i.e. browser cannot fetch load wasm files from file:// URls but apparently electroc apps can?

@@ -796,6 +833,23 @@ jobs:
# some native-dependent tests fail because of the lack of native
# headers on emsdk-bundled clang
test_targets: "other skip:other.test_native_link_error_message"
test-browser-webview:
# We don't use `bionic` here since its tool old to run recent node versions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# We don't use `bionic` here since its tool old to run recent node versions:
# We don't use `bionic` here since it's too old to run recent node versions:

title: "browser"
# Skip test_4gb_fail as it OOMs on the current bot
test_targets: "
browser skip:browser.test_4gb_fail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this entire suite is large (and as a result slow) I would support picking a select few to run.

@sbc100 sbc100 changed the title Webview tests [ci] Add webview tests Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants