-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add webview tests #22042
base: main
Are you sure you want to change the base?
[ci] Add webview tests #22042
Conversation
title: "browser" | ||
# Skip test_4gb_fail as it OOMs on the current bot | ||
test_targets: " | ||
browser skip:browser.test_4gb_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to be running all browser tests in this mode or should we just run a select few?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this entire suite is large (and as a result slow) I would support picking a select few to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can write a specific test for loading from file:// URLs since that is the only different that I currently know of between webview and non-webview browsers. i.e. browser cannot fetch load wasm files from file:// URls but apparently electroc apps can?
.circleci/config.yml
Outdated
@@ -796,6 +833,23 @@ jobs: | |||
# some native-dependent tests fail because of the lack of native | |||
# headers on emsdk-bundled clang | |||
test_targets: "other skip:other.test_native_link_error_message" | |||
test-browser-webview: | |||
# We don't use `bionic` here since its tool old to run recent node versions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# We don't use `bionic` here since its tool old to run recent node versions: | |
# We don't use `bionic` here since it's too old to run recent node versions: |
title: "browser" | ||
# Skip test_4gb_fail as it OOMs on the current bot | ||
test_targets: " | ||
browser skip:browser.test_4gb_fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this entire suite is large (and as a result slow) I would support picking a select few to run.
This PR adds a 'webview' browser and uses it to run CI tests.