[wasm64] Fix offscreen canvas and offscreen framebuffer #20678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
3 times, most recently
from
777b729 to
c16e7ea
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 10, 2023
Also, make one of the pthread_keys static since its only used in this one file. Split out from emscripten-core#20678
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 10, 2023
Also, make one of the pthread_keys static since its only used in this one file. Split out from emscripten-core#20678
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 10, 2023
Also, make one of the pthread_keys static since its only used in this one file. Split out from emscripten-core#20678
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
from
c16e7ea to
3bff00d
Compare
sbc100
changed the title
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
2 times, most recently
from
91cd141 to
2846d0b
Compare
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
2 times, most recently
from
82d739d to
a6d8375
Compare
sbc100
changed the title
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
from
a6d8375 to
c6e4982
Compare
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
from
c6e4982 to
18af8d2
Compare
sbc100
changed the title
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
4 times, most recently
from
10218cd to
28688cd
Compare
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
from
28688cd to
4350bc4
Compare
kripken
approved these changes
Nov 13, 2023
sbc100
force-pushed
the
browser_wasm64_gl_threading
branch
from
4350bc4 to
a1767ef
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 3, 2024
This was changed in emscripten-core#20678 Fixes: emscripten-core#20993
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 3, 2024
This was changed in emscripten-core#20678 Fixes: emscripten-core#20993
sbc100
added a commit
that referenced
this pull request
Jan 3, 2024
ghost
mentioned this pull request
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 11, 2025
I can't see why this was done this way in the first place? The `PARAM_I64` support existed back in cdf7bc5 when proxying was first added. Perhaps it was just that the `EM_FUNC_SIG_XX` macros were harder write before `I64` was replaced with `J` in emscripten-core#20678? Fixes: emscripten-core#25932
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 11, 2025
I can't see why this was done this way in the first place? The `PARAM_I64` support existed back in cdf7bc5 when proxying was first added. Perhaps it was just that the `EM_FUNC_SIG_XX` macros were harder write before `I64` was replaced with `J` in emscripten-core#20678? Fixes: emscripten-core#25932
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 11, 2025
I can't see why this was done this way in the first place? The `PARAM_I64` support existed back in cdf7bc5 when proxying was first added. Perhaps it was just that the `EM_FUNC_SIG_XX` macros were harder write before `I64` was replaced with `J` in emscripten-core#20678? Fixes: emscripten-core#25932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.