Fix for SINGLE_FILE + sync compilation + missing atob
#20587
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 1, 2023
| @@ -8885,7 +8885,11 @@ def do_test(cmd): | |||
|
|
|||
| @requires_v8 | |||
| def test_single_file_shell(self): | |||
| self.do_runf('hello_world.c', emcc_args=['-sSINGLE_FILE']) | |||
There was a problem hiding this comment.
How did this pass before? requires_v8 should have run the test in v8, and without building with ENVIRONMENT=shell that should have failed?
There was a problem hiding this comment.
requires_v8 injects -sENVRIONMENT=shell.. but in this case I thought it better to be explicit.. maybe not ?
There was a problem hiding this comment.
In that case I'd remove it. It confused me, and also it would be confusing in the logging to have the flag appear twice.
In this configuration the `atob` polfill is required but was not being installed until after `createWasm` which (in the case of SINGLE_FILE) depends on `atob`. See emscripten-core#20349
sbc100
force-pushed
the
single_file_sync_compile
branch
from
e152c38
to
d1ee3b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this configuration the
atobpolfill is required but was not being installed until aftercreateWasmwhich (in the case of SINGLE_FILE) depends onatob.See #20349