Fix for AUDIO_WORKLET + MODULARIZE

[imiskolee]

move the js code to fix syntax error.

Fixes: #19796

[sbc100]

I guess we should add a test case for AUDIO_WORKLET + MODULARIZE? Perhaps modify one of the existing tests using @parameterize? (And verify that it fails without this patch).

[sbc100]

(I hope you don't mind, I re-titled the PR to describe what it does)

[imiskolee]

I guess we should add a test case for AUDIO_WORKLET + MODULARIZE? Perhaps modify one of the existing tests using @parameterize? (And verify that it fails without this patch).

[imiskolee]

@sbc100 I has a compile issue now:

1. when I used bash '-sAUDIO_WORKLET', '-sWASM_WORKERS','-sMODULARIZE=1' , it's showing error:

test/runner browser.test_audio_worklet_modularize

emcc: error: Due to collision in variable name "Module", the shell file "/Users/miskolee/develop/src/github.com/emscripten/src/shell.html" is not compatible with build options "-sMODULARIZE -sEXPORT_NAME=Module". Either provide your own shell file, change the name of the export to something else to avoid the name collision. (see https://github.com/emscripten-core/emscripten/issues/7950 for details)

I also tried

'-sAUDIO_WORKLET', '-sWASM_WORKERS','-sMODULARIZE=1','-sEXPORT_NAME=MyModule'

emcc: error: Customizing EXPORT_NAME requires that the HTML be customized to use that name (see https://github.com/emscripten-core/emscripten/issues/10086)

'-sAUDIO_WORKLET', '-sWASM_WORKERS','-sEXPORT_ES6=1'

[imiskolee]

AudioWorkletGlobalScope have not wasmTable field. so *.aw.js file also failed. Uncaught TypeError: Cannot read properties of undefined (reading 'get')
at new WasmAudioWorkletProcessor (TestWasm.aw.js:30:51)

Looks like the wasmTable can not pass to worker, but the aw.js depends this.

[imiskolee]

Hi,Team: I already add the test case and can be test pass with

test/runner browser.test_audio_worklet_modularize

please take a look this.

[imiskolee]

@juj please check this.

[sbc100]

Hmm.. it looks like there is some kind circleci issue going on here where it trying to use you plan to run these CI jobs.. @kripken do you know about this issue?

[sbc100]

Something must have changed or be broken with circleci because it didn't do this for the previous run in this PR

[imiskolee]

what's next step?

[sbc100]

We just need the CI tests to pass.

In this case it looks like we are being effected by a circleci configuration issue: #20430

[kripken]

Looks like the CircleCI issue is resolved here, landing.