WasmFS JS API: Implement allocate #19602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jun 13, 2023
| stat("/dir1", &rmdirStat); | ||
| assert(S_ISDIR(rmdirStat.st_mode)); | ||
| stat("/dir2", &rmdirStat); | ||
| assert(S_ISDIR(rmdirStat.st_mode)); |
There was a problem hiding this comment.
If the reason for the name change is to avoid a collision, another option is to add a scope,
{
struct stat s;
..
}But the more explicit name also seems good by itself, either sgtm.
Or, it might be nice to split up the tests into their own functions, as the new test here.
There was a problem hiding this comment.
There was some collision after merging in the other tests, but I did move each test to its own function in the utime PR after a suggestion from Sam, so the collision should be fixed (#19561). I was originally planning on changing the names back to struct stat s after the tests as individual functions are merged in.
kripken
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
allocate. I did not see any tests forFS.allocate, so added new ones totest_fs_js_api.c.I also had to change the type of the
__syscall_fallocateto useint64_tinstead ofuint64_tso that negative numbers would correctly throw error handling. Withuint64_tsetSize()would abort without an error code, since it was interpreting negative numbers incorrectly. Now, the syscall correctly returns an error code if either offset or length is negative.