-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WasmFS JS API: Implement truncate #19543
Merged
kripken
merged 26 commits into
emscripten-core:main
from
jameshu15869:library-wasmfs-truncate
Jun 13, 2023
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e0d56a1
implement truncate and ftruncate with tests
jameshu15869 f305495
handle negative size
jameshu15869 58bd56a
fix merge conflicts
jameshu15869 cfc0213
Merge branch 'main' of https://github.com/emscripten-core/emscripten …
jameshu15869 b354716
fix merge conflicts
jameshu15869 408fcc3
clean up
jameshu15869 5eaaeba
Merge branch 'main' into library-wasmfs-truncate
jameshu15869 08773f5
loggin
jameshu15869 044e8e4
passing tests with logging
jameshu15869 a0a3aa6
clean up
jameshu15869 ad54b31
fix merge conflicts
jameshu15869 23c4326
fix js_api returns
jameshu15869 e857699
clean up test
jameshu15869 c1b3f46
remove extra line
jameshu15869 d3a8326
call syscall from js
jameshu15869 279f9a5
working with int32_t
jameshu15869 c924202
int64_t not working
jameshu15869 750a978
working u53toi64
jameshu15869 a0e4ca5
clean up
jameshu15869 b1703ff
clean up test
jameshu15869 0cabd03
clean up
jameshu15869 b262202
use spliti64
jameshu15869 058dfa6
clean up
jameshu15869 f057bc4
remove unused import
jameshu15869 1d18411
remove white space
jameshu15869 bce2613
use wrapper calls instead of raw syscals
jameshu15869 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with all these changes it would be good to look for other tests that already use this API, if any? If we were previously disabling, or not running, those tests under WASMFS it would be good to enable them now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything explicitly calling
FS.truncate()
in the test dir, so I added them totest_fs_js_api
for now. Are there any places besides the test directory that could potentially contain disabled tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it would only be in the test dir. I guess we had not tests for that API. Thanks for looking into it. Hopefully after we are done with this we will have much better test coverage for the JS API!