Skip to content

Don't break when -lc and -sSIDE_MODULE are both passed #19414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoodmane wants to merge 1 commit into from
Closed

Don't break when -lc and -sSIDE_MODULE are both passed #19414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions emcc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4167,6 +4167,8 @@ def process_libraries(state, linker_inputs):
new_flags.append((i, flag))
continue
lib = strip_prefix(flag, '-l')
if lib == "c":
continue
Copy link
Collaborator

@sbc100 sbc100 May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should instead avoid adding native_lib to forced_stdlibs on line 4180, and if we should do it for all native system libs.. do we ever want to allow the side module to include a system library? Shouldn't they always get linking into the main module?

Perhaps we should at least do this for all default libraries (e.g. libc++, libcompiler_rt, etc)


logger.debug('looking for library "%s"', lib)
js_libs, native_lib = building.map_to_js_libs(lib)
Expand Down
4 changes: 4 additions & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13493,3 +13493,7 @@ def test_preload_module(self, args):
def test_standalone_whole_archive(self):
self.emcc_args += ['-sSTANDALONE_WASM', '-pthread', '-Wl,--whole-archive', '-lbulkmemory', '-lstandalonewasm', '-Wl,--no-whole-archive']
self.do_runf(test_file('hello_world.c'))

def test_lc_side_module(self):
create_file('side.c', 'int sidey() { return 42; }')
self.run_process([EMCC, '-sSIDE_MODULE', 'side.c', '-o', 'libside.so', '-lc'])