Update MINIMUM_NODE_VERSION to match the emsdk version#18464
Update MINIMUM_NODE_VERSION to match the emsdk version#18464
Conversation
We don't test emscripten on older version of node than this so it seems reasonable to require at least this version.
|
Last time we tried this was back in #9333 and it got reverted.. so this needs some more consideration. |
|
We evidently have not supported 4.1.1 for quite some time. Based on the empirical running of the test suite I found the following. 4.1.1: Looking at https://packages.ubuntu.com/search?keywords=nodejs I picked that next LTS version focal (20.04LTS) which is 10.19.0: This globalThis references was first added in #18266 which landed fairly recently and was released in 3.1.28, so it could just be that folks wanting to use 10.19.0 have not noticed this yet. If it replace So it seems like we could make 10.19.0 work with a little effort. I'll give that a go. |
We don't test emscripten on older version of node than this so it seems reasonable to require at least this version.