Fix for running of side module static constructors #18311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
dschuff
reviewed
Dec 2, 2022
sbc100
force-pushed
the
dlopen_ctors_side_module
branch
from
1574e93
to
0c0a588
Compare
dschuff
approved these changes
Dec 2, 2022
sbc100
force-pushed
the
dlopen_ctors_side_module
branch
from
0c0a588
to
1ecaa1f
Compare
sbc100
force-pushed
the
dlopen_ctors_side_module
branch
from
1ecaa1f
to
6cad811
Compare
This bug only only applied when a non-main thread was the first one to `dlopen` a given side module.
sbc100
force-pushed
the
dlopen_ctors_side_module
branch
from
6cad811
to
2c680c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug only only applied when a non-main thread was the first one to
dlopena given side module.