Set EM_CONFIG rather then running emsdk_env.sh. #18012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
em_config
branch
2 times, most recently
from
7c1489a to
f8e26bb
Compare
Since emscripten-core/emsdk#1110 landed emsdk no longer set `EM_CONFIG` so we need to do that (in order to make our local version of emscripten use the config from emsdk).
Collaborator
Author
|
Landing TBR to get the CI tests passing again. |
Member
|
Fine for getting CI tests passing. But I thought setting EM_CONFIG shouldn't be necessary anymore when using emsdk? Is this going to affect our users? |
Collaborator
Author
|
No, I don't think it should effect users who want to use emsdk. I this case we are trying to use emsdk with our own out-of-tree version of emscripten. It this case it seems reasonable to set EM_CONFIG to point to the emsdk config file. |
Member
|
Makes sense, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since emscripten-core/emsdk#1110 landed emsdk no longer set
EM_CONFIGso we need to do that (in order to make our local version of emscripten use the config from emsdk).