Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failures when any parent directory is {"type": "module"} #17451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix build failures when any parent directory is {"type": "module"} #17451

wants to merge 3 commits into from

Commits on Jul 15, 2022

  1. fix build failures when any parent directory is {"type": "module"} 

    This fixes hard-to-debug failures when any parent directory has
package.json with {"type": "module"} in it.

Before emconfigure / conftest could fail with config.log error:
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ""

The fix forces commonjs mode for generated Node scripts.

fixes emscripten-core#13551
fixes emscripten-core#17431
    @shamrin
    shamrin committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    4a83cfb View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. write js executable to .cjs file, with a shell wrapper

    @shamrin
    shamrin committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    c87888a View commit details
    Browse the repository at this point in the history

  2. Delete commonjs-loader.mjs

    @shamrin
    shamrin committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    d87fd15 View commit details
    Browse the repository at this point in the history