Add pthread + dylink test for side-module-defined C++ comdat info. NFC #17180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test will only pass once that corresponding llvm fix lands: https://reviews.llvm.org/D127333 See #17150
|
Should be good to merge now.. PTAL |
kripken
approved these changes
Jun 15, 2022
| '-sSIDE_MODULE=1']) | ||
| self.do_runf( | ||
| 'main.cpp', | ||
| 'main: Foo typeid: 3Foo\nside: Foo typeid: 3Foo\n', |
There was a problem hiding this comment.
Will this 3 remain the same in the future? How is that constant determined?
There was a problem hiding this comment.
Its the number of characters in Foo.
I guess this mangling could possibly change, but only if/when we update libc++/libc++abi I imagine.. which is rare.
There was a problem hiding this comment.
Apparently the string format itself is considered implementation defined: https://en.cppreference.com/w/cpp/types/type_info/name
sbc100
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will only pass once that corresponding llvm fix lands:
https://reviews.llvm.org/D127333
See #17150