Switch to the new LLVM pass manager #13818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM has made the switch, and are releasing it to the general public
any day now in the new release. It doesn't really make sense for us to
be more careful about things than them.
Fixes #13427. As noted there, this does regress some things like the
minor code size increase in the test updates here, but also it helps on
some benchmarks. The overall tradeoff is good in LLVM's eyes.
For the LLVM compile time regression, I looked at how #13420
tried to fix it, but it's actually quite hard - almost every single macro
use there needs to be put in its own function, to avoid really bad
compile times.
-O3
is just very very aggressive on those loops itseems. Instead of a big refactoring, I disabled those tests on
-O3
specifically.
-O2
is close enough to give us good coverage thereI think - the main difference between them is inlining, after all.