Correctly fix windows parentheses mix-up #13723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was attempted to fix in emscripten-core#13698 by escaping `)` but it turned out to be an incomplete fix, because it fixed the breaking tests then but broke other ones instead depending on their syntax. This PR tries to fix it correctly by using `enabledelayedexpansion` feature of batch files. We can enable delayed expansion of variables within a batch file by ``` @SETLOCAL enabledelayedexpansion ``` And if you use variables not by the usual syntax `%VAR%` but `!VAR!`, it is expanded in a delayed manner, after all parentheses for `if`s and `else`s are expanded.
sbc100
approved these changes
Mar 22, 2021
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
nice! thanks for figuring this out.
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
sbc100
added a commit
that referenced
this pull request
May 22, 2021
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was attempted to fix in #13698 by escaping
)but it turnedout to be an incomplete fix, because it fixed the breaking tests then
but broke other ones instead depending on their syntax. This PR tries to
fix it correctly by using
enabledelayedexpansionfeature of batchfiles. We can enable delayed expansion of variables within a batch file
by
And if you use variables not by the usual syntax
%VAR%but!VAR!, itis expanded in a delayed manner, after all parentheses for
ifs andelses are expanded.