Enable custom locations in create_entry_points.py #13679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
entry_point_remap
branch
from
5d37e4e to
7519b5e
Compare
Collaborator
|
Can this land after #13498? |
sbc100
referenced
this pull request
Mar 16, 2021
…iles. (#13464) * Simplify the use of emprofile and fix issue with empty generated profiles. * Change EM_PROFILE_TOOLCHAIN environment variable to simpler "EMPROFILE", so that users only need to remember one word "EMPROFILE" to use the toolchain profiler. * Add -c and -o flags and simplify generated profile filename * Add mouse hover tooltips to emprofile results.
sbc100
force-pushed
the
entry_point_remap
branch
from
7519b5e to
26224e0
Compare
As and example the python code for the emdump tool lives in tools/emdump.py, but we want the entey point to be at the top level of emscripten. Hopefully this will help with #13464
sbc100
force-pushed
the
entry_point_remap
branch
from
26224e0 to
3ffd1a3
Compare
Collaborator
Author
|
Rebased. PTAL |
juj
approved these changes
Mar 17, 2021
Collaborator
|
Overall I'm starting to feel like this automatic script creation is more complex than hand-maintaining them would be. |
Collaborator
Author
|
I've got some ideas on how to improve this over time. |
Collaborator
Author
|
I see a lot of value in managing this stuff centrally. The bug in the hand-edited |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As and example the python code for the emdump tool lives in
tools/emdump.py, but we want the entey point to be at the top
level of emscripten.
Hopefully this will help with #13464