Cleanup tools/emprofile.py and add more testing. NFC #13403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Not quite ready for review yet. |
Collaborator
Author
|
Should be good now. |
kripken
approved these changes
Feb 2, 2021
Member
|
It looks like this might be broken on windows: https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket.appspot.com/8856310836080327520/+/steps/Emscripten_testsuite__upstream__other_/0/stdout |
dschuff
added a commit
that referenced
this pull request
Feb 3, 2021
sbc100
added a commit
that referenced
this pull request
Feb 4, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Feb 5, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Feb 5, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Apr 23, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Aug 6, 2021
Run the new test on windows to prove that it works there. This was reverted in 13410
sbc100
added a commit
that referenced
this pull request
Aug 10, 2021
#13416) Run the new test on windows to prove that it works there. This was reverted in 13410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.