Add EM_COMPILER_WRAPPER as replacement for EMMAKEN_COMPILER #12380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I could potentially split out the |
This allows a compiler wrapper to be installed around the underlying clang, but without changing the location of the llvm installation or having to know where it is. This is in contrast to other option LLVM_ROOT which points emscripten at a different llvm build (and also replaces not just clang but all the other llvm tools). This mimikes the corresponding CMAKE option CMAKE_<LANG>_COMPILER_WRAPPER. The reason we allow the inner compiler to be wrapped like this is that distributing the whole of emscripten to a distcc farm or gomacc farm would otherwise be required. Fixes: #12340
sbc100
force-pushed
the
compiler_wrapper
branch
from
dd66ca1 to
a888f12
Compare
kripken
approved these changes
Sep 30, 2020
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm with site docs. In "Building Projects" perhaps?
also add to changelog please.
Collaborator
Author
|
Done |
sbc100
force-pushed
the
compiler_wrapper
branch
from
577c4da to
cb4dc68
Compare
|
@sbc100 Does it allow to specify a wrapper around emcc as well? Like my ccskip.py |
Collaborator
Author
|
No that would be different thing. This is like an inner wrapper for clang that emcc runs. What you want is some kind of outer wrapper that replaces emcc completely. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a compiler wrapper to be installed around the
underlying clang, but without changing the location of the
llvm installation or having to know where it is.
This is in contrast to other option LLVM_ROOT which points
emscripten at a different llvm build (and also replaces not
just clang but all the other llvm tools).
This mimikes the corresponding CMAKE option
CMAKE__COMPILER_WRAPPER.
The reason we allow the inner compiler to be wrapped like this
is that distributing the whole of emscripten to a distcc farm
or gomacc farm would otherwise be required.
Fixes: #12340