Asyncify: Support for new add-list, and updates for binaryen list changes #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jun 18, 2020
Comment on lines
+7
to
+8
| struct Structy { | ||
| virtual int virty() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new
ASYNCIFY_ADD_LIST, and update existing list namesfollowing the updates in Binaryen, so that now we have
ASYNCIFY_ADD_LISTtoadd a function,
ASYNCIFY_REMOVE_LISTto remove one (previously this wascalled
ASYNCIFY_BLACKLIST), andASYNCIFY_ONLY_LISTto set a list of theonly functions to instrument and no others (previously this was called
ASYNCIFY_WHITELIST).The updated lists also handle indirect calls properly, so that if you
use
ASYNCIFY_IGNORE_INDIRECTand then add (using either theadd-list or the only-list) all the functions that are on the stack when
pausing, then things will work (for more, see
WebAssembly/binaryen#2913). A new test is
added to show this.