Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastcomp: RTTI/dynamic_cast does not work between MAIN_MODULE and SIDE_MODULE #8376

Closed
sbc100 opened this issue Mar 31, 2019 · 2 comments
Closed

fastcomp: RTTI/dynamic_cast does not work between MAIN_MODULE and SIDE_MODULE #8376

sbc100 opened this issue Mar 31, 2019 · 2 comments
Labels
wontfix

Comments

@sbc100
Copy link
Collaborator

sbc100 commented Mar 31, 2019

This problem was reported as part of #8268.

The issue exists because we do not implement COMDAT/weak symbols and therefore a copy of the RTTI information exists both the SIDE_MODULE and the MAIN_MODULE which means that pointer typeinfo pointers can't be compared for equality between the two modules.
sbc100 added a commit that referenced this issue Mar 31, 2019
@sbc100
Add failing test of rtti (dynamic_cast) combined with dynamic libraries
e1b283e 
See #8376 and #8268.
@sbc100 sbc100 mentioned this issue Mar 31, 2019
Merged
sbc100 added a commit that referenced this issue Apr 1, 2019
@sbc100
Add failing test of rtti (dynamic_cast) combined with dynamic librari…
d995936 
…es (#8377)

See #8376 and #8268.
@sbc100 sbc100 mentioned this issue Apr 3, 2019
Closed
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this issue May 21, 2019
@sbc100 @VirtualTim
Add failing test of rtti (dynamic_cast) combined with dynamic librari…
bcb5474 
…es (emscripten-core#8377)

See emscripten-core#8376 and emscripten-core#8268.
@sbc100
Copy link
Collaborator Author

sbc100 commented Jul 18, 2019

This issue is fixed under wasm backend.

@sbc100 sbc100 changed the title RTTI/dynamic_cast does not work between MAIN_MODULE and SIDE_MODULE fastcomp: RTTI/dynamic_cast does not work between MAIN_MODULE and SIDE_MODULE Jul 18, 2019
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Jul 18, 2020
@sbc100 sbc100 closed this as completed Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbc100