Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acorn-optimizer.js trips over async functions #11431

Closed
bmeurer opened this issue Jun 17, 2020 · 1 comment · Fixed by #11435
Closed

acorn-optimizer.js trips over async functions #11431

bmeurer opened this issue Jun 17, 2020 · 1 comment · Fixed by #11435

Comments

@bmeurer
Copy link
Contributor

bmeurer commented Jun 17, 2020

When using async functions in the pre or post JS and combining that with -s MAXIMUM_MEMORY=4GB the acorn-optimizer.js trips over the async function during parsing. Looks like acorn could use an update :-)
kripken added a commit that referenced this issue Jun 17, 2020
@kripken
test; fixes #11431
81d0e5c
kripken added a commit that referenced this issue Jun 17, 2020
@kripken
test; fixes #11431
c985573
@kripken kripken mentioned this issue Jun 17, 2020
Merged
@kripken
Copy link
Member

kripken commented Jun 17, 2020 •
edited
Loading

Fix in #11435 - looks like we had the Acorn language set to ES2015.

kripken added a commit that referenced this issue Jun 17, 2020
@kripken
Bump Acorn JS version to ES2018 (#11435)
56dc964 
We set the version to 6 (2015) when we added Acorn, probably to
keep it as close as possible to the old pre-Acorn parser. But the
default in our version is 9 (2018) so we may as well switch to that,
and that fixes #11431 (8 - 2017 - would have been enough for
that specific bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Acorn JS version to ES2018 emscripten-core/emscripten
2 participants
@kripken @bmeurer