This repository was archived by the owner on Nov 1, 2021. It is now read-only.
When building relocatable code lookup function addresses dynamically via fp$foo functions#259
Merged
When building relocatable code lookup function addresses dynamically via fp$foo functions#259
fp$foo functions#259Conversation
kripken
reviewed
Apr 29, 2019
| } | ||
| Out << "],"; | ||
|
|
||
| Out << "\"externFunctions\": ["; |
Member
There was a problem hiding this comment.
isn't externs enough for the purpose here - idn't externFunctions duplicating part of it?
Collaborator
Author
There was a problem hiding this comment.
externs is for external global data and we want to be able to handle the corresponding g$ and fp$ helpers separately.
Member
There was a problem hiding this comment.
Can't emscripten.py tell which of the externs are functions and which are globals? Then it could create the helpers there? Or is this just easier to do here?
Collaborator
Author
There was a problem hiding this comment.
No. IIUC emscripten.py gets all the info it has from the metadata so we need to encode this somehow.
Collaborator
Author
There was a problem hiding this comment.
I could instead list them in the declares sections with the fp$ prefix so we would know which decleres we of this type.
Member
There was a problem hiding this comment.
Sounds good either way - you know this code the best at this point.
sbc100
force-pushed
the
function_addresses
branch
from
eb38dd4 to
a4dce6f
Compare
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 4, 2019
There is upstream fastcomp change coming which addresses function pointer equality between wasm modules (i.e. SIDE_MODULE/MAIN_MODULE): emscripten-core/emscripten-fastcomp#259 This change prepares for that change by handling the new externFunctions metadata attribute. This new key represents a list of all non-static functions in a relocatable module which are address taken. The module will call fp$<name>() in order to find out the runtime address (table entry) for such functions. Once both these changes land they they will fix #8268.
sbc100
force-pushed
the
function_addresses
branch
from
a4dce6f to
1a34ed0
Compare
kripken
approved these changes
Sep 5, 2019
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 5, 2019
There is upstream fastcomp change coming which addresses function pointer equality between wasm modules (i.e. SIDE_MODULE/MAIN_MODULE): emscripten-core/emscripten-fastcomp#259 This change prepares for that change by handling the new externFunctions metadata attribute. This new key represents a list of all non-static functions in a relocatable module which are address taken. The module will call fp$<name>() in order to find out the runtime address (table entry) for such functions. Once both these changes land they they will fix #8268.
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 5, 2019
There is upstream fastcomp change coming which addresses function pointer equality between wasm modules (i.e. SIDE_MODULE/MAIN_MODULE): emscripten-core/emscripten-fastcomp#259 This change prepares for that change by handling the new externFunctions metadata attribute. This new key represents a list of all non-static functions in a relocatable module which are address taken. The module will call fp$<name>() in order to find out the runtime address (table entry) for such functions. Once both these changes land they they will fix #8268.
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 5, 2019
) There is upstream fastcomp change coming which addresses function pointer equality between wasm modules (i.e. SIDE_MODULE/MAIN_MODULE): emscripten-core/emscripten-fastcomp#259 This change prepares for that change by handling the new externFunctions metadata attribute. This new key represents a list of all non-static functions in a relocatable module which are address taken. The module will call fp$<name>() in order to find out the runtime address (table entry) for such functions. Once both these changes land they they will fix #8268.
…via `fp$foo` functions This means that the dynamic linker then assigned function pointers and both main module and side module use `fp$foo` accessors to lookup function addresses, just like they do for global addresses. This allows the test_dylink_function_pointer_equality test in emscripten to pass. See emscripten-core/emscripten#8268.
sbc100
force-pushed
the
function_addresses
branch
from
1a34ed0 to
391bf5b
Compare
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 12, 2019
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 12, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…scripten-core#9393) There is upstream fastcomp change coming which addresses function pointer equality between wasm modules (i.e. SIDE_MODULE/MAIN_MODULE): emscripten-core/emscripten-fastcomp#259 This change prepares for that change by handling the new externFunctions metadata attribute. This new key represents a list of all non-static functions in a relocatable module which are address taken. The module will call fp$<name>() in order to find out the runtime address (table entry) for such functions. Once both these changes land they they will fix emscripten-core#8268.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that the dynamic linker then assigned function pointers
and both main module and side module use
fp$fooaccessors to lookupfunction addresses, just like they do for global addresses.
This allows the test_dylink_function_pointer_equality test in emscripten
to pass.
See emscripten-core/emscripten#8268.