Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(listener): enforce reload conn and stream opts #346

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Feb 25, 2025

0.2 branch only,

breaking change: listener reload must be called with listener opts, conn opts and stream opts.

Enforce updating conn and stream opt while reloading the listener.

We used to support reload with listen opts or with a three elems tuple containing listen opts, conn opts and stream opts. This has proved to be confusing and error-prone.

@coveralls
Copy link

coveralls commented Feb 25, 2025

Pull Request Test Coverage Report for Build 13518848273

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 86.299%

Files with Coverage Reduction New Missed Lines %
c_src/quicer_dgram.c 3 83.33%
c_src/quicer_config.c 6 87.11%
Totals Coverage Status
Change from base Build 13074476717: -0.2%
Covered Lines: 4088
Relevant Lines: 4737

💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/listener-reload branch from 1dbeb5e to 74a7b2c Compare February 25, 2025 10:17
@qzhuyan qzhuyan changed the title feat(listener): support reload conn and stream opts feat(listener): enforce reload conn and stream opts Feb 25, 2025
@qzhuyan qzhuyan merged commit fc59463 into emqx:main Feb 25, 2025
51 checks passed
@qzhuyan qzhuyan deleted the dev/william/listener-reload branch February 25, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants