Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations/ tweak conversion script and fix locale #12634

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eadams17
Copy link
Member

@eadams17 eadams17 commented Dec 5, 2024

WHAT

tweak script that converts english and translated text entries into CSV doc, as well as fix Tagalog locale in TranslationPrompts

WHY

we don't need linebreaks for these CSV values and we want the correct locale for Tagalog (note: I already fixed these entries manually in the rails console so that they have the correct locale value-- this is just for cleanup)

HOW

remove wrap_text formatter function from script and change Tagalog locale from ts to tl

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)
https://www.notion.so/quill/Translation-Project-Complete-Translations-of-other-Languages-11dd42e6f94180559387d370d57ea7af

What have you done to QA this feature?

(Provide enough detail that a reviewer could assess whether additional QA should be done. For larger projects, additionally use the Engineer Feature Testing Notion template. Review Guidelines if needed: https://www.notion.so/quill/Github-PR-QA-Guidelines-49e99fc965654ceeb8c6249bd9d181d7)
ran script locally and on staging

PR Checklist Your Answer
Have you added and/or updated tests? yes
Have you deployed to Staging? yes
Self-Review: Have you done an initial self-review of the code below on Github? yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants