Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreate genai trial runner and all associated pages in evidence cms #12632

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

emilia-friedberg
Copy link
Member

  • add type to table and color code it

  • finish updates to activities index page

  • possible to create a new activity with an ai type

  • nav updates

  • snapshot updates

  • wip

  • wip before i mess up further

  • wip -- actually saving working

  • saving works and they populate correctly too!

  • clean up

  • get invalid relevant texts populated on the activity form

  • small edits

  • tests

  • fix lint errors

  • remove trailing whitespace

  • clean up

  • fixes

  • fix test

  • all refactors except service object

  • refactor gen ai stuff into a service object; tests still pass

  • finish specs

  • fix lint errors

  • jamie's requested revisions

  • other refactors

  • thomas' revisions

  • fixes

  • try again

  • datasets pages (datasets pages #12473)

  • wip

  • get basic tables loading

  • lots of cleanup to do but UPLOADING WORKS

  • style index page

  • successfully handling errors for new datasets

  • modal upload looks much better

  • set up individual stem vault pages

  • split out files

  • frontend tests

  • fix lints and tests

  • backend tests

  • more lint fixes

  • import fix

  • make sure notes stuff works with migration in place

  • fix lint error

  • fix function to accommodate has_many stem_vaults

  • fix test time incongruity

  • handle loading state

  • css adjustments

  • more styling

  • update snapshots

  • one more snapshot

  • add task_type to dataset on json request save

  • remove trailing whitespace

  • individual dataset page (individual dataset page #12486)

  • wip

  • get basic tables loading

  • lots of cleanup to do but UPLOADING WORKS

  • style index page

  • successfully handling errors for new datasets

  • modal upload looks much better

  • set up individual stem vault pages

  • split out files

  • frontend tests

  • fix lints and tests

  • backend tests

  • more lint fixes

  • import fix

  • make sure notes stuff works with migration in place

  • fix lint error

  • fix function to accommodate has_many stem_vaults

  • fix test time incongruity

  • handle loading state

  • css adjustments

  • more styling

  • update snapshots

  • one more snapshot

  • add task_type to dataset on json request save

  • remove trailing whitespace

  • wip

  • partway down road of updating datatable but there may be a better way

  • trial table rendering

  • make it possible to edit dataset notes

  • fix lint errors

  • Revert "partway down road of updating datatable but there may be a better way"

This reverts commit e1a31fc.

  • bad commit

  • reorg

  • more tests and reorg

  • remove invalid aria attribute

  • update interfaces

  • guideline creation and display is working

  • hiding and unhiding guidelines also works

  • backend updates to create and set default relevant texts

  • all relevant text flows working

  • tests and minor accessibility updates

  • more jest test updates

  • backend tests and minor css changes

  • fix lint errors

  • lint errors and scss fixes

  • styling tweaks

  • fix capitalization error

  • fix

  • Bs individual dataset change to use nested attributes (Bs individual dataset change #12499)

  • Use nested attributes for dataset_relevant_text create and update

  • fix specs

  • Fix specs


  • test updates and fixes

  • thomas suggestions


  • trial runner page pt 1 (trial runner page pt 1 #12503)

  • wip

  • get basic tables loading

  • lots of cleanup to do but UPLOADING WORKS

  • style index page

  • successfully handling errors for new datasets

  • modal upload looks much better

  • set up individual stem vault pages

  • split out files

  • frontend tests

  • fix lints and tests

  • backend tests

  • more lint fixes

  • import fix

  • make sure notes stuff works with migration in place

  • fix lint error

  • fix function to accommodate has_many stem_vaults

  • fix test time incongruity

  • handle loading state

  • css adjustments

  • more styling

  • update snapshots

  • one more snapshot

  • add task_type to dataset on json request save

  • remove trailing whitespace

  • wip

  • partway down road of updating datatable but there may be a better way

  • trial table rendering

  • make it possible to edit dataset notes

  • fix lint errors

  • Revert "partway down road of updating datatable but there may be a better way"

This reverts commit e1a31fc.

  • bad commit

  • reorg

  • more tests and reorg

  • remove invalid aria attribute

  • update interfaces

  • guideline creation and display is working

  • hiding and unhiding guidelines also works

  • backend updates to create and set default relevant texts

  • all relevant text flows working

  • tests and minor accessibility updates

  • more jest test updates

  • backend tests and minor css changes

  • fix lint errors

  • lint errors and scss fixes

  • styling tweaks

  • fix capitalization error

  • fix

  • wip

  • wip

  • Bs individual dataset change to use nested attributes (Bs individual dataset change #12499)

  • Use nested attributes for dataset_relevant_text create and update

  • fix specs

  • Fix specs


  • test updates and fixes

  • wip and qa

  • making new llm prompt modal pretty

  • creating new prompt template variables works

  • view works and so does new template creation

  • make setters work

  • frontend tests

  • rspec tests

  • lint and test fixes

  • lint fix

  • remove duplicated line


  • trial runner page pt 2 (trial runner page pt 2 #12517)

  • move stuff around and refactor guideline keys

  • add show test to dataset controller spec

  • updating queries to make cache invalidation possible

  • update tests

  • lint fixes

  • checkability for guidelines

  • update dataset relevant texts and guidelines to handle selection

  • tests

  • thomas suggestions

  • trial runner page pt 3 (trial runner page pt 3 #12518)

  • prompt example tables displaying correctly

  • saving new prompt examples works

  • we are running trials

  • actually use default relevant text id

  • backend tests

  • frontend tests

  • fix lint error

  • individual trial page part one (individual trial page part one #12528)

  • move stuff around and refactor guideline keys

  • add show test to dataset controller spec

  • updating queries to make cache invalidation possible

  • update tests

  • lint fixes

  • checkability for guidelines

  • update dataset relevant texts and guidelines to handle selection

  • tests

  • prompt example tables displaying correctly

  • saving new prompt examples works

  • we are running trials

  • actually use default relevant text id

  • thomas suggestions

  • backend tests

  • frontend tests

  • fix lint error

  • wip

  • qa fixes

  • add modals and histogram

  • add confusion matrix

  • frontend tests

  • backend tests

  • lints and one test fix

  • minor scss updates

  • fix snapshot

  • fix

  • test updates

  • some width updates

  • brendan's suggestion

  • individual trial page pt 2 (individual trial page pt 2 #12531)

  • hacked but working

  • functionality good, but still routing weirdness

  • add comments for routes that aren't working

  • frontend tests

  • backend tests

  • lint/test fixes

  • test fixes and hopefully some minor speed gain

  • test edits

  • data subset page (data subset page #12535)

  • update the individualdataset and related components to handle subsets

  • additional minor adjustment

  • tests etc

  • oops

  • fix test and lint

  • trial comparisons page (trial comparisons page #12543)

  • everything but individual trial header looks good

  • got table headers rendering all the relevant information

  • fix logic around colors

  • test updates

  • refactor out some more shared constants

  • update datatable and related tests

  • frontend tests

  • lint fixes

  • backend tests

  • fix lint

  • remove stray punctuation mark

  • fix canvas integration form tests

  • eric-suggested changes

  • fix broken test

  • fix lint error

  • some qa updates for evidence cms (some qa updates for evidence cms #12569)

  • qa updates

  • tests

  • fix one other frontend test

  • brendan suggestions

  • llm prompt templates page (llm prompt templates page #12582)

  • qa updates

  • tests

  • fix one other frontend test

  • wip -- getting pieces in place

  • move snapshot

  • bulk update is working

  • frontend is styled and looking good

  • update param name

  • backend tests

  • frontend tests

  • minor width adjustments

  • minor scss update

  • lint fixes

  • adjust timestamp so tests pass

  • revision suggestions

  • adjust checkbox scss

  • lint fixes

  • negated matchers


WHAT

WHY

HOW

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)

What have you done to QA this feature?

(Provide enough detail that a reviewer could assess whether additional QA should be done. For larger projects, additionally use the Engineer Feature Testing Notion template. Review Guidelines if needed: https://www.notion.so/quill/Github-PR-QA-Guidelines-49e99fc965654ceeb8c6249bd9d181d7)

PR Checklist Your Answer
Have you added and/or updated tests? (The answer should mostly be 'YES'. If you answer 'NO', please justify.)
Have you deployed to Staging? (Possible answers: YES, Not yet - deploying now!, NO - non-app change, NO - tiny change)
Self-Review: Have you done an initial self-review of the code below on Github?

* add type to table and color code it

* finish updates to activities index page

* possible to create a new activity with an ai type

* nav updates

* snapshot updates

* wip

* wip before i mess up further

* wip -- actually saving working

* saving works and they populate correctly too!

* clean up

* get invalid relevant texts populated on the activity form

* small edits

* tests

* fix lint errors

* remove trailing whitespace

* clean up

* fixes

* fix test

* all refactors except service object

* refactor gen ai stuff into a service object; tests still pass

* finish specs

* fix lint errors

* jamie's requested revisions

* other refactors

* thomas' revisions

* fixes

* try again

* datasets pages (#12473)

* wip

* get basic tables loading

* lots of cleanup to do but UPLOADING WORKS

* style index page

* successfully handling errors for new datasets

* modal upload looks much better

* set up individual stem vault pages

* split out files

* frontend tests

* fix lints and tests

* backend tests

* more lint fixes

* import fix

* make sure notes stuff works with migration in place

* fix lint error

* fix function to accommodate has_many stem_vaults

* fix test time incongruity

* handle loading state

* css adjustments

* more styling

* update snapshots

* one more snapshot

* add task_type to dataset on json request save

* remove trailing whitespace

* individual dataset page (#12486)

* wip

* get basic tables loading

* lots of cleanup to do but UPLOADING WORKS

* style index page

* successfully handling errors for new datasets

* modal upload looks much better

* set up individual stem vault pages

* split out files

* frontend tests

* fix lints and tests

* backend tests

* more lint fixes

* import fix

* make sure notes stuff works with migration in place

* fix lint error

* fix function to accommodate has_many stem_vaults

* fix test time incongruity

* handle loading state

* css adjustments

* more styling

* update snapshots

* one more snapshot

* add task_type to dataset on json request save

* remove trailing whitespace

* wip

* partway down road of updating datatable but there may be a better way

* trial table rendering

* make it possible to edit dataset notes

* fix lint errors

* Revert "partway down road of updating datatable but there may be a better way"

This reverts commit e1a31fc.

* bad commit

* reorg

* more tests and reorg

* remove invalid aria attribute

* update interfaces

* guideline creation and display is working

* hiding and unhiding guidelines also works

* backend updates to create and set default relevant texts

* all relevant text flows working

* tests and minor accessibility updates

* more jest test updates

* backend tests and minor css changes

* fix lint errors

* lint errors and scss fixes

* styling tweaks

* fix capitalization error

* fix

* Bs individual dataset change to use nested attributes (#12499)

* Use nested attributes for dataset_relevant_text create and update

* fix specs

* Fix specs

---------

Co-authored-by: Brendan Shean <[email protected]>

* test updates and fixes

* thomas suggestions

---------

Co-authored-by: Brendan Shean <[email protected]>

* trial runner page pt 1 (#12503)

* wip

* get basic tables loading

* lots of cleanup to do but UPLOADING WORKS

* style index page

* successfully handling errors for new datasets

* modal upload looks much better

* set up individual stem vault pages

* split out files

* frontend tests

* fix lints and tests

* backend tests

* more lint fixes

* import fix

* make sure notes stuff works with migration in place

* fix lint error

* fix function to accommodate has_many stem_vaults

* fix test time incongruity

* handle loading state

* css adjustments

* more styling

* update snapshots

* one more snapshot

* add task_type to dataset on json request save

* remove trailing whitespace

* wip

* partway down road of updating datatable but there may be a better way

* trial table rendering

* make it possible to edit dataset notes

* fix lint errors

* Revert "partway down road of updating datatable but there may be a better way"

This reverts commit e1a31fc.

* bad commit

* reorg

* more tests and reorg

* remove invalid aria attribute

* update interfaces

* guideline creation and display is working

* hiding and unhiding guidelines also works

* backend updates to create and set default relevant texts

* all relevant text flows working

* tests and minor accessibility updates

* more jest test updates

* backend tests and minor css changes

* fix lint errors

* lint errors and scss fixes

* styling tweaks

* fix capitalization error

* fix

* wip

* wip

* Bs individual dataset change to use nested attributes (#12499)

* Use nested attributes for dataset_relevant_text create and update

* fix specs

* Fix specs

---------

Co-authored-by: Brendan Shean <[email protected]>

* test updates and fixes

* wip and qa

* making new llm prompt modal pretty

* creating new prompt template variables works

* view works and so does new template creation

* make setters work

* frontend tests

* rspec tests

* lint and test fixes

* lint fix

* remove duplicated line

---------

Co-authored-by: Brendan Shean <[email protected]>

* trial runner page pt 2 (#12517)

* move stuff around and refactor guideline keys

* add show test to dataset controller spec

* updating queries to make cache invalidation possible

* update tests

* lint fixes

* checkability for guidelines

* update dataset relevant texts and guidelines to handle selection

* tests

* thomas suggestions

* trial runner page pt 3 (#12518)

* prompt example tables displaying correctly

* saving new prompt examples works

* we are running trials

* actually use default relevant text id

* backend tests

* frontend tests

* fix lint error

* individual trial page part one (#12528)

* move stuff around and refactor guideline keys

* add show test to dataset controller spec

* updating queries to make cache invalidation possible

* update tests

* lint fixes

* checkability for guidelines

* update dataset relevant texts and guidelines to handle selection

* tests

* prompt example tables displaying correctly

* saving new prompt examples works

* we are running trials

* actually use default relevant text id

* thomas suggestions

* backend tests

* frontend tests

* fix lint error

* wip

* qa fixes

* add modals and histogram

* add confusion matrix

* frontend tests

* backend tests

* lints and one test fix

* minor scss updates

* fix snapshot

* fix

* test updates

* some width updates

* brendan's suggestion

* individual trial page pt 2 (#12531)

* hacked but working

* functionality good, but still routing weirdness

* add comments for routes that aren't working

* frontend tests

* backend tests

* lint/test fixes

* test fixes and hopefully some minor speed gain

* test edits

* data subset page (#12535)

* update the individualdataset and related components to handle subsets

* additional minor adjustment

* tests etc

* oops

* fix test and lint

* trial comparisons page (#12543)

* everything but individual trial header looks good

* got table headers rendering all the relevant information

* fix logic around colors

* test updates

* refactor out some more shared constants

* update datatable and related tests

* frontend tests

* lint fixes

* backend tests

* fix lint

* remove stray punctuation mark

* fix canvas integration form tests

* eric-suggested changes

* fix broken test

* fix lint error

* some qa updates for evidence cms (#12569)

* qa updates

* tests

* fix one other frontend test

* brendan suggestions

* llm prompt templates page (#12582)

* qa updates

* tests

* fix one other frontend test

* wip -- getting pieces in place

* move snapshot

* bulk update is working

* frontend is styled and looking good

* update param name

* backend tests

* frontend tests

* minor width adjustments

* minor scss update

* lint fixes

* adjust timestamp so tests pass

* revision suggestions

* adjust checkbox scss

* lint fixes

* negated matchers

---------

Co-authored-by: Brendan Shean <[email protected]>
@emilia-friedberg emilia-friedberg merged commit d91c39a into production Dec 5, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants