Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Staggered release recalculate cron job (#12607) #12621

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

brendanshean
Copy link
Member

  • Create job

  • update with group

  • Change to distinct

  • Extract some constants

  • Change DEFAULT_BATCH_SIZE

  • Use find_each

  • Remove parameters

  • Add cron job

  • Remove with_index in loop

  • Dan suggestions

  • Thomas suggsetion

WHAT

WHY

HOW

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)

What have you done to QA this feature?

(Provide enough detail that a reviewer could assess whether additional QA should be done. For larger projects, additionally use the Engineer Feature Testing Notion template. Review Guidelines if needed: https://www.notion.so/quill/Github-PR-QA-Guidelines-49e99fc965654ceeb8c6249bd9d181d7)

PR Checklist Your Answer
Have you added and/or updated tests? (The answer should mostly be 'YES'. If you answer 'NO', please justify.)
Have you deployed to Staging? (Possible answers: YES, Not yet - deploying now!, NO - non-app change, NO - tiny change)
Self-Review: Have you done an initial self-review of the code below on Github?

* Create job

* update with group

* Change to distinct

* Extract some constants

* Change DEFAULT_BATCH_SIZE

* Use find_each

* Remove parameters

* Add cron job

* Remove with_index in loop

* Dan suggestions

* Thomas suggsetion
@brendanshean brendanshean merged commit 1798ddc into production Dec 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant