Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec failure invovling time #12617

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

brendanshean
Copy link
Member

WHAT

Fix a bug with calculating the student dashboard metrics

WHY

It fails when it is the second day of the month.

HOW

Set the day of the month to 10.

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)

What have you done to QA this feature?

PR Checklist Your Answer
Have you added and/or updated tests? YES
Have you deployed to Staging? NO
Self-Review: Have you done an initial self-review of the code below on Github? YES

@brendanshean brendanshean merged commit 955b75d into develop Dec 2, 2024
17 checks passed
@brendanshean brendanshean deleted the bs-fix-dashboard-metric-spec-bug branch December 2, 2024 19:43
brendanshean added a commit that referenced this pull request Dec 2, 2024
Fix spec failure invovling time (#12617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants