Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused organization data from Vitally #12585

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Conversation

cissyxyu
Copy link
Contributor

WHAT

Now that we've updated the Vitally serializers with more granular data, we no longer need the generic diagnostic traits, so we can remove all of this data from the serializer payload.

WHY

To reduce the amount of unnecessary calculations we're doing.

HOW

Remove these traits and update tests.

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

https://www.notion.so/quill/Product-Board-30f97e4eb01246dbb8264253fb385073?p=2fb92d4ba89847af9da661fc78710556&pm=c

What have you done to QA this feature?

Run all tests and ensure passing.

PR Checklist Your Answer
Have you added and/or updated tests? yes
Have you deployed to Staging? no - small change and no new code
Self-Review: Have you done an initial self-review of the code below on Github? yes

Copy link
Contributor

@anathomical anathomical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing code!

@cissyxyu cissyxyu merged commit 2d6287a into develop Nov 28, 2024
17 checks passed
@cissyxyu cissyxyu deleted the remove-org-diagnostics branch November 28, 2024 11:04
cissyxyu added a commit that referenced this pull request Nov 28, 2024
Remove unused organization data from Vitally (#12585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants