-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic/ add new ell translations #12087
Conversation
…Core into add-new-ell-translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I don't think we need to do this now, especially because this is time-sensitive, but at some point it might be nice to do some clean up where we make all those keys into constants since they're duplicated across all the files.
…Core into add-new-ell-translations
Diagnostic/ add new ell translations (#12087)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eadams17 looks like this was a mistake!
WHAT
add new ell translations for the new ELL Diagnostics
WHY
we have new instruction and cue translations
HOW
update all of the translation JSON files with the new key-value pairs
Screenshots
(If applicable. Also, please censor any sensitive data)
![Screen Shot 2024-07-16 at 2 30 32 PM](https://private-user-images.githubusercontent.com/25959584/349260010-b393ba0d-56b0-4ebf-bea9-3ee923ca58e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3MDkzNjQsIm5iZiI6MTcyNDcwOTA2NCwicGF0aCI6Ii8yNTk1OTU4NC8zNDkyNjAwMTAtYjM5M2JhMGQtNTZiMC00ZWJmLWJlYTktM2VlOTIzY2E1OGUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDIxNTEwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhMDRiNGEzZmEwYzg1MDM0YzBhNWU0NzQ2MzljMDg5N2ZiMDFlNjdiZWUwZWZjMjg2M2RjNjI4OTE1OWY5NjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pYugIojb4Mhfbq8vdAKMr_jDtKtW_c9iZwmAEfgaS3g)
Notion Card Links
(Please provide links to any relevant Notion card(s) relevant to this PR.)
https://www.notion.so/quill/Add-New-ELL-Diagnostic-Translations-20f9eb0d6fea4aab83f2fd617ef9dbc4?pvs=4
What have you done to QA this feature?
(Provide enough detail that a reviewer could assess whether additional QA should be done. For larger projects, additionally use the Engineer Feature Testing Notion template. Review Guidelines if needed: https://www.notion.so/quill/Github-PR-QA-Guidelines-49e99fc965654ceeb8c6249bd9d181d7)
clicked through each question of each new diagnostic for each language on staging (v tedious)