Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge package jsons #11419

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Merge package jsons #11419

wants to merge 2 commits into from

Conversation

happythenewsad
Copy link
Contributor

@happythenewsad happythenewsad commented Jan 16, 2024

WHAT

Merges client/package.json into package.json

WHY

having two package.jsons is tech debt: it is extra complication with no added value.

  • it requires managing two separate node_modules caches
  • it prevents upgrading to npm 8.x in local environments slack
  • it maintains repetitive scripts (example: npm run jest is first evaluated in package.json, then delegated to client/package.json

HOW

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

https://www.notion.so/quill/Product-Board-30f97e4eb01246dbb8264253fb385073?p=f451f08525af46799cf76f4b16f78669&pm=s

PR Checklist Your Answer
Have you added and/or updated tests? (The answer should mostly be 'YES'. If you answer 'NO', please justify.)
Have you deployed to Staging? (Possible answers: YES, Not yet - deploying now!, NO - non-app change, NO - tiny change)
Self-Review: Have you done an initial self-review of the code below on Github?
Spec Review: Have you reviewed the spec and ensured this meets requirements and/or matches design mockups? (N/A or Yes)

@@ -0,0 +1,6 @@
module.exports = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel.config.cjs is not preferred over .babelrc

Source: jestjs/jest@1818d84#diff-04c6e90faac2675aa89e2176d2eec7d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant