Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup production build in Vue3 #1603

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Rollup production build in Vue3 #1603

merged 4 commits into from
Aug 27, 2024

Conversation

joseacabaneros
Copy link
Member

@joseacabaneros joseacabaneros commented Aug 22, 2024

  • Migrate scss to css, scoped when only necessary, and clean up. CSS nesting and scoped doesn't generate a right CSS code. Flatten class selectors and use CSS to avoid preprocessors
  • Use @vitejs/plugin-vue instead of deprecated rollup-plugin-vue
  • Use a simple custom CSS injector build/tools/inject-css.js in vue-plugin-styles
  • Simplify the build.ts content
  • Make apiDocumentation plugin work in the build process 🥳

@joseacabaneros joseacabaneros requested a review from a team as a code owner August 22, 2024 14:14
@joseacabaneros
Copy link
Member Author

There is an issue with no-scoped styles in layout. They are no-scoped and have shared class names, so styles of all layouts are applied to the same. It can be replicated in serve with Vite.
WIP in a workaround for layouts.

@diegopf diegopf merged commit ed587b1 into vue3-update-rc Aug 27, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants