Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update to vue3 #499

Merged
merged 45 commits into from
Oct 3, 2024
Merged

Feat/update to vue3 #499

merged 45 commits into from
Oct 3, 2024

Conversation

diegopf
Copy link
Contributor

@diegopf diegopf commented Sep 5, 2024

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

diegopf and others added 23 commits August 24, 2024 17:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@victorcg88 victorcg88 marked this pull request as ready for review September 23, 2024 13:55
@victorcg88 victorcg88 requested a review from a team as a code owner September 23, 2024 13:55
@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

joseacabaneros
joseacabaneros reviewed Sep 27, 2024
View reviewed changes
src/components/main.vue Outdated Show resolved Hide resolved
src/components/my-history/my-history-icon-bw.vue Outdated Show resolved Hide resolved
src/components/pre-search/pre-search-manager.vue Outdated Show resolved Hide resolved
src/components/pre-search/pre-search-manager.vue Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

joseacabaneros
joseacabaneros previously approved these changes Sep 30, 2024
View reviewed changes
victorcg88
victorcg88 previously approved these changes Oct 3, 2024
View reviewed changes
@diegopf diegopf dismissed stale reviews from victorcg88 and joseacabaneros via 4605f7c October 3, 2024 08:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Check PR 499 preview 👀

https://x.test.empathy.co/preview/499/index.html

joseacabaneros
joseacabaneros approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@joseacabaneros joseacabaneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the e2e @victorcg88! Nice not to see any webpack dependency finally ✌🏾

@diegopf diegopf merged commit a19b011 into main Oct 3, 2024
4 checks passed
@diegopf diegopf deleted the feat/update-to-vue3 branch October 3, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorcg88 victorcg88 victorcg88 approved these changes

@joseacabaneros joseacabaneros joseacabaneros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegopf @joseacabaneros @victorcg88