Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/performance tweaks #373

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Test/performance tweaks #373

wants to merge 32 commits into from

Conversation

CachedaCodes
Copy link
Contributor

Don't merge

annacv and others added 16 commits November 6, 2023 12:44
@annacv
feat(nextQueries): set maxNextQueriesPerGroup using xControls
cf615e7 
EMP-2722
@annacv
feat(layout): set columns using xControls
554f8ef 
EMP-2722
@annacv
chore: rename export in composable to avoid large length imports
de13239 
EMP-2722
@annacv
feat: use xControls composable in semantics
293c79a 
EMP-2722
@annacv
chore: change dress filter, collection not filterable anymore
2fed166 
EMP-2722
@annacv
feat: return one single computed to make composable scalable
d77c080 
EMP-2722
@annacv
feat: use the full object property path instead of 2 params
9543790 
EMP-2722
@annacv
feat: use getSafePropertyChain utility function
9498705 
EMP-2722
@annacv
feat(composables): create use-store composable + use it in XControls …
4cfca1e 
…composable

EMP-2722
@annacv
feat(app): rm provider as module is accessible using composable f()
74e6dd2 
EMP-2722
@annacv
chore: rm test useXControls feat from custom-next-query-preview
9e8cd12 
EMP-2722
@annacv
chore: rename composable to avoid large string
49f0f15 
EMP-2722
@annacv @CachedaCodes
Update src/composables/use-experience-controls.composable.ts
8b41dca 
Co-authored-by: Guillermo Cacheda <[email protected]>
@annacv
chore: PR fixes
879ef27 
EMP-2722
@CachedaCodes
chore: refactor
f6b110d
@CachedaCodes
test: refactor index
c07d193
@CachedaCodes CachedaCodes requested a review from a team as a code owner November 13, 2023 11:29
@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

1 similar comment
@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@support-empathy
Copy link
Contributor

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

@github-actions GitHub Actions
Copy link

Check PR 373 preview 👀

https://x.test.empathy.co/preview/373/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CachedaCodes @support-empathy @annacv