Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide full empathize when there are no suggestions #310

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Aug 8, 2023

Pull request template

Currently full predictive layer is open when there are no suggestions to display. Maybe in the archetype looks good but in several customers we have to change it each time.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-1642

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Search for a query with no suggestions, for example: print midi dress women

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner August 8, 2023 06:49
@jenkins-empathy
Copy link

PR #310 preview deployed in https://x.test.empathy.co/preview/310/index.html

@mavmaf mavmaf merged commit 194f829 into main Aug 8, 2023
2 checks passed
@mavmaf mavmaf deleted the bugfix/EMP-1642-do-not-open-full-predictive-layes-when-there-are-no-suggestions branch August 8, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants