feat: implement css injector in archetype #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedaCodes
commented
Aug 2, 2023
package.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| "dependencies": { | |||
| "@empathyco/x-adapter": "^8.0.0-alpha.22", | |||
| "@empathyco/x-adapter-platform": "^1.0.0-alpha.79", | |||
| "@empathyco/x-archetype-utils": "^0.1.0-alpha.15", | |||
| "@empathyco/x-archetype-utils": "file:../x/packages/x-archetype-utils/empathyco-x-archetype-utils-1.0.0-alpha.2.tgz", | |||
There was a problem hiding this comment.
Change with your generated build file
Merged
8 tasks
…ate-styles-with-shadow-dom # Conflicts: # package-lock.json # package.json
mavmaf
reviewed
Aug 9, 2023
| @@ -108,7 +108,7 @@ const customCommands: CustomCommands = { | |||
| cy.typeQuery(query).type('{enter}'); | |||
| }); | |||
| }, | |||
| typeQuery: query => cy.getByDataTest('search-input').type(query), | |||
| typeQuery: query => cy.getByDataTest('search-input').type(query, { force: true }), | |||
There was a problem hiding this comment.
needed but not desirable.
Seems to be working without forcing it in newer Cypress versions cypress-io/cypress#21433
|
PR #308 preview deployed in https://x.test.empathy.co/preview/308/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the css injector in the archetype.
This PR should encapsulate the tailwindcss styles inside the x overlay.
Test it by setting a button with the class
x-buttonin theindex.html. When the injection is applied, it should look like a regular button. When it's not applied, it should have the styles of the X design system.The injection only works with the build process, so run
build:serveto see it.