Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update archetype with X project #307

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Aug 2, 2023

Pull request template

Currently, when we use the live env, we can't define it as an empty string ('') because the request will fail, it will put two . one after the other. This doesn't make much sense. We have fixed this problem in the X project, and now we have to update X in the archetype.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-1625

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Add in the URL env=live.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner August 2, 2023 14:04
@jenkins-empathy
Copy link

PR #307 preview deployed in https://x.test.empathy.co/preview/307/index.html

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annacv annacv merged commit 6630ac9 into main Aug 4, 2023
2 checks passed
@annacv annacv deleted the bugfix/EMP-1625-deploy-in-archetype branch August 4, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants