Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minor adjustments in archetype design #304

Merged
merged 4 commits into from
Aug 8, 2023
Merged

feat: minor adjustments in archetype design #304

merged 4 commits into from
Aug 8, 2023

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Jul 31, 2023 •
edited by jira bot
Loading

Pull request template

Restyle with minor adjustments the archetype following the designs: https://www.figma.com/file/mYfJZHn668mGEGf61Sji6m/X-Archetype?node-id=72%3A468&mode=dev

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-771

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Follow the task description.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner July 31, 2023 13:29
@jenkins-empathy
Copy link

PR #304 preview deployed in https://x.test.empathy.co/preview/304/index.html

herrardo
herrardo reviewed Aug 2, 2023
View reviewed changes
src/components/my-history/custom-my-history.vue
{{ $t('myHistory.noHistory') }}
</p>
</div>
<div v-else />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we assuming that we have to delete the My History graphic based on the designs?

https://www.figma.com/file/mYfJZHn668mGEGf61Sji6m/X-Archetype?node-id=3027%3A22233&mode=dev

There are two versions in there..

CachedaCodes
CachedaCodes suggested changes Aug 3, 2023
View reviewed changes
src/components/search/results/custom-next-query-preview.vue Outdated
<NextQuery :suggestion="nextQuery" class="x-button-tight x-button max-desktop:x-px-16">
<NextQuery
:suggestion="nextQuery"
class="x-button-tight x-button x-text-lead-50 max-desktop:x-px-16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class="x-button-tight x-button x-text-lead-50 max-desktop:x-px-16"
class="x-button-tight x-button x-button-lead max-desktop:x-px-16"

src/components/search/results/partial-results.vue Outdated
@@ -5,7 +5,7 @@
<template #header>
<PartialQueryButton
:query="partialResult.query"
class="x-button-tight x-button max-desktop:x-px-16"
class="x-button-tight x-button x-text-lead-50 max-desktop:x-px-16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class="x-button-tight x-button x-text-lead-50 max-desktop:x-px-16"
class="x-button-tight x-button x-button-lead max-desktop:x-px-16"

src/components/search/no-results-message.vue Outdated
@@ -1,22 +1,27 @@
<template>
<i18n
v-if="$x.noResults"
class="x-no-results-message x-text1 x-flex x-flex-col x-items-center x-gap-8 x-break-words x-bg-neutral-10 x-p-24 x-text-center desktop:x-text1-lg"
class="x-no-results-message x-text1 x-mt-24 x-flex x-items-center x-break-words x-bg-neutral-10 x-py-8 x-text-center x-text-neutral-90 desktop:x-flex-wrap desktop:x-justify-center desktop:x-gap-8 desktop:x-text1-lg desktop:x-py-24"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing so many text colors from x-text1 to x-text-neutral-90?

Copy link
Contributor Author

@lauramargar lauramargar Aug 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many texts need the color x-text-neutral-90, I mean this color #283034, but by default, all these texts have associated this color #000000. We could separate these text changes in another task and investigate how to fix them.

src/components/search-box.vue Outdated
@@ -16,9 +16,9 @@

<SearchButton
v-if="isDesktopOrGreater || !$x.query.searchBox"
class="x-input-group-button-primary"
class="x-input-group-button-primary x-bg-neutral-90"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work design wise, we don't have a button with a background color of neutral-90. We lose the hovering interactions with this.

@jenkins-empathy
Copy link

PR #304 preview deployed in https://x.test.empathy.co/preview/304/index.html

@jenkins-empathy
Copy link

PR #304 preview deployed in https://x.test.empathy.co/preview/304/index.html

CachedaCodes
CachedaCodes suggested changes Aug 8, 2023
View reviewed changes
public/snippet-script.js
@@ -48,7 +48,6 @@ const instance = popFromURLParameters('instance') || 'empathy';
const env = getEnv();
const scope = popFromURLParameters('scope') || 'desktop';
const lang = popFromURLParameters('lang') || 'en';
const device = popFromURLParameters('device') || 'mobile';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this functionality, change this line to

const device = popFromURLParameters('device') || undefined;

public/snippet-script.js Outdated
@@ -63,7 +62,6 @@ window.initX = {
env,
scope,
lang,
device,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this

@jenkins-empathy
Copy link

PR #304 preview deployed in https://x.test.empathy.co/preview/304/index.html

@CachedaCodes CachedaCodes merged commit 43b96a3 into main Aug 8, 2023
3 checks passed
@CachedaCodes CachedaCodes deleted the feature/EMP-771-archetype-minor-adjustments-to-the-designs branch August 8, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herrardo herrardo herrardo left review comments

@CachedaCodes CachedaCodes CachedaCodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauramargar @herrardo @CachedaCodes