Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update x-components and fix scroll bug #301

Merged
merged 1 commit into from
Jul 27, 2023
Merged

fix: update x-components and fix scroll bug #301

merged 1 commit into from
Jul 27, 2023

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Jul 27, 2023 •
edited by jira bot
Loading

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-1584

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner July 27, 2023 11:31
@jenkins-empathy
Copy link

PR #301 preview deployed in https://x.test.empathy.co/preview/301/index.html

annacv
annacv approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annacv annacv merged commit d5593f0 into main Jul 27, 2023
2 checks passed
@annacv annacv deleted the bugfix/EMP-1584-deploy-to-archetype branch July 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annacv annacv annacv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lauramargar @annacv