fix: update x-components to fix bug with suggestions #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #299 preview deployed in https://x.test.empathy.co/preview/299/index.html |
lauramargar
reviewed
Jul 24, 2023
CachedaCodes
deleted the
bugfix/EMP-1510-no-opening-of-empathize-without-suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-1510
Motivation and context
Update x-components version to fix a bug with the x-plugin returning all the suggestions instead of just the ones that should be rendered. Then fixing the full width empathize view.
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Search for something that doesn't have suggestions and then click the search bar. It shouldn't open awkwardly to an empty box.