Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collapse header when scroll in tablet or less #297

Conversation

lauramargar
Copy link
Contributor

EMP-1185

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner July 4, 2023 12:08
@jenkins-empathy
Copy link

PR #297 preview deployed in https://x.test.empathy.co/preview/297/index.html

</LocationProvider>
<div v-if="$x.query.search && !$x.redirections.length">
<MobileToolbar class="x-mb-16" />
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We could move the "x-layout-item" class to the container <div> to keep the structure more similar to desktop, but up to you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already tried to move the "x-layout-item" class to the <div>, but it makes the collapse not working properly. It collapses like in 2 steps instead of in 1.

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lauramargar lauramargar merged commit e4f2f6b into main Jul 4, 2023
@lauramargar lauramargar deleted the bugfix/EMP-1185-toolbar-collapse-doesnt-work-properly-in-widths-between-desktop-and-mobile branch July 4, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants