Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tagging): add displayClick to recommendations #294

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

ajperezbau
Copy link
Contributor

Motivation and context

Track clicks on the custom and sliding recommendations

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ajperezbau ajperezbau requested a review from a team as a code owner June 16, 2023 08:18
Copy link
Contributor

@herrardo herrardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add it also to custom-query-preview.vue component. Suggestion:

image

@jenkins-empathy
Copy link

PR #294 preview deployed in https://x.test.empathy.co/preview/294/index.html

@ajperezbau ajperezbau requested a review from herrardo June 16, 2023 08:29
@jenkins-empathy
Copy link

PR #294 preview deployed in https://x.test.empathy.co/preview/294/index.html

@ajperezbau ajperezbau merged commit 55fb68d into main Jun 19, 2023
2 checks passed
@ajperezbau ajperezbau deleted the feature/EMP-1110-add-displayclick-to-topclicked branch June 19, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants