Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: review arquetype tests #293

Merged
merged 3 commits into from
Jun 20, 2023
Merged

test: review arquetype tests #293

merged 3 commits into from
Jun 20, 2023

Conversation

mavmaf
Copy link
Contributor

@mavmaf mavmaf commented Jun 15, 2023

Motivation and context

Not many changes at the end. Child filters for hierarchical facets are not being returned, so test is kept as skipped until further development.
Also, minor adjustment for multipleinteraction test: sometimes is was failing when looking for the result carts due to the presence of a banner.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@mavmaf mavmaf requested a review from a team as a code owner June 15, 2023 13:55
@mavmaf mavmaf marked this pull request as draft June 15, 2023 13:55
@jenkins-empathy
Copy link

PR #293 preview deployed in https://x.test.empathy.co/preview/293/index.html

1 similar comment
@jenkins-empathy
Copy link

PR #293 preview deployed in https://x.test.empathy.co/preview/293/index.html

@mavmaf mavmaf changed the title un-skip facets test test: review arquetype tests Jun 19, 2023
@mavmaf mavmaf marked this pull request as ready for review June 19, 2023 14:04
@ajperezbau ajperezbau self-requested a review June 20, 2023 07:34
@jenkins-empathy
Copy link

PR #293 preview deployed in https://x.test.empathy.co/preview/293/index.html

Copy link
Contributor

@ajperezbau ajperezbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@ajperezbau ajperezbau merged commit c0c777d into main Jun 20, 2023
@ajperezbau ajperezbau deleted the test/EMP-1053-review-tests branch June 20, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants