feat: emit display click on semantic queries click #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #292 preview deployed in https://x.test.empathy.co/preview/292/index.html |
|
PR #292 preview deployed in https://x.test.empathy.co/preview/292/index.html |
herrardo
previously approved these changes
Jun 14, 2023
dhalfageme
previously approved these changes
Jun 14, 2023
|
PR #292 preview deployed in https://x.test.empathy.co/preview/292/index.html |
ajperezbau
approved these changes
Jun 14, 2023
ajperezbau
approved these changes
Jun 14, 2023
ajperezbau
deleted the
feature/EMP-1067-emit-display-click-on-semantic-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-1067
Motivation and context
We need to send the tagging event of display click when a semantic query is clicked.
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Search for
sofa-> Click a semantic result -> check in the network that the event was sent with the correct payload -> search forsilla-> Click a semantic result -> check in the network that the event was sent with the correct payload -> repeat ad infinitum -> regret your choices in life