feat: collapse mobile header in scrolling #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #289 preview deployed in https://x.test.empathy.co/preview/289/index.html |
|
PR #289 preview deployed in https://x.test.empathy.co/preview/289/index.html |
|
PR #289 preview deployed in https://x.test.empathy.co/preview/289/index.html |
CachedaCodes
approved these changes
Jun 14, 2023
|
PR #289 preview deployed in https://x.test.empathy.co/preview/289/index.html |
CachedaCodes
deleted the
feature/EMP-1004-as-a-shopper-i-want-the-mobile-header-to-collapse-in-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-1004
Motivation and context
Provide the user a better visualization with more space for the results.
We have created a new component (
mobile-sub-header) where we add all the elements that we want to be hidden (related-tagsandmobile-toolbar). We have also created the animation that we separated into 2 files,collapse-heigth-animation.scssandis-scrolling-up.mixin.ts.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
When you scroll over the result list, the related tags, toolbar and selected filters should hide.