Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap on long words in the no results message #152

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

CachedaCodes
Copy link
Contributor

EX-6537

Motivation and context

When searching for long, single-word queries the message in the no-results-message component didn't wrap. This made the mobile view look really bad. This PR makes it so it would break long words and wrap.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Search for a query by smashing your keyboard a couple of times and see how the no-results-message looks.

@CachedaCodes CachedaCodes requested a review from a team as a code owner July 20, 2022 13:04
@ajperezbau ajperezbau self-requested a review July 20, 2022 13:21
Copy link
Contributor

@ajperezbau ajperezbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@tiborux tiborux merged commit 3de06c0 into main Jul 21, 2022
@tiborux tiborux deleted the bugfix/EX-6537-visualization-of-long-queries branch July 21, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants