Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add x-components XModal #150

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

javieri-empathy
Copy link
Contributor

EX-6701

Adds x-components xmodal

Known issues

Because of how layouts are configured, you can't click on the overlay, as there are other layouts elements overlapping this element. So you are not able to close the XModal by clicking this element.

@tiborux tiborux marked this pull request as ready for review July 22, 2022 07:07
@tiborux tiborux requested a review from a team as a code owner July 22, 2022 07:07
@tiborux tiborux changed the title WIP: feat: add x-components XModal feat: add x-components XModal Jul 22, 2022
src/components/desktop/desktop.vue Outdated Show resolved Hide resolved
src/components/mobile/mobile.vue Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
@tajespasarela tajespasarela merged commit eb2b99c into main Jul 25, 2022
@tajespasarela tajespasarela deleted the feature/EX-6701-use-x-components-xmodal branch July 25, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants