feat(my-history): add modal to confirm disable history queries #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismmdev
suggested changes
Jul 18, 2022
| @@ -5,7 +5,7 @@ | |||
| <DeviceDetector @DeviceProvided="$setLocaleDevice" :breakpoints="breakpoints" /> | |||
| <Tagging /> | |||
| <UrlHandler env="env" /> | |||
| <XModal v-if="isOpen" :openEvents="openEvents" /> | |||
| <XModal v-if="isOpen" :openEvents="openEvents" :closeEvents="closeEvents" /> | |||
There was a problem hiding this comment.
With this change we can't close the XModal now, as the Close button is emitting UserClickedCloseEventsModal instead of the newly configured UserClickedCloseX event.
Modify desktop.vue line 35:
<Close closingEvent="UserClickedCloseX" class="x-button--ghost x-padding--right-00">
Modify mobile.vue line 16:
<Close
closingEvent="UserClickedCloseX"
mnavarroespinosa
approved these changes
Jul 19, 2022
mnavarroespinosa
deleted the
feature/EX-6517-confirm-dialog-to-disable-history-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EX-6517